Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new post-SSO verification control #493

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Nov 4, 2024

🗣 Description

Add new policy to Common Controls to reflect the addition of a new setting relating to post-SSO verification. Also clarify the purpose of post-SSO verification.

💭 Motivation and context

Closes #453.

🧪 Testing

N/A; holding off on actual code implementation for now.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto added this to the Driftwood milestone Nov 4, 2024
@adhilto adhilto requested review from buidav and mdueltgen November 4, 2024 19:11
@adhilto adhilto self-assigned this Nov 4, 2024
@adhilto adhilto linked an issue Nov 4, 2024 that may be closed by this pull request
2 tasks
@adhilto adhilto changed the title Add 3.2 to common controls Add new post-SSO verification control Nov 6, 2024
baselines/commoncontrols.md Outdated Show resolved Hide resolved
baselines/commoncontrols.md Outdated Show resolved Hide resolved
baselines/commoncontrols.md Outdated Show resolved Hide resolved
@buidav buidav self-requested a review November 6, 2024 21:27
@adhilto adhilto merged commit 61d7ad2 into main Nov 6, 2024
5 checks passed
@adhilto adhilto deleted the 453-post-sso-verification-ui-admin-center-change branch November 6, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post-SSO verification UI admin center change
3 participants